fix potential panic on numa resources info updating in snapshot

[qi-min]

What type of PR is this?

bug

What this PR does / why we need it:

There is panic risk in snapshot when numatopology is added and updated in short time before snapshot

Which issue(s) this PR fixes:

Fixes #
#4891

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[gemini-code-assist]

Summary of Changes

Hello @qi-min, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that could lead to a system panic during snapshot operations. The fix ensures the robustness of NUMA resource information updates by explicitly checking for nil NumaSchedulerInfo before proceeding, thereby preventing crashes in scenarios where NUMA topology changes rapidly.

Highlights

• Panic Prevention: Introduced a nil check for NumaSchedulerInfo before updating NUMA resource information, specifically addressing a panic risk when NUMA topology is rapidly added and updated during snapshot operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a potential panic in RefreshNumaSchedulerInfoByCrd by adding a nil check for ni.NumaSchedulerInfo. The change is concise and effective. I have added one comment regarding a related potential panic in the same function that would be beneficial to address for improved robustness.

[volcano-sh-bot]

@JesseStutler: GitHub didn't allow me to request PR reviews from the following users: qi-min.

Note that only volcano-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @qi-min

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JesseStutler]

/approve
/lgtm

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JesseStutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [JesseStutler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JesseStutler]

/cherrypick release-1.13

[JesseStutler]

/cherrypick release-1.12

[volcano-sh-bot]

@JesseStutler: new pull request created: #4897

Details

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[volcano-sh-bot]

@JesseStutler: new pull request created: #4898

Details

In response to this:

/cherrypick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.