[release-1.12] Fix: Changes to task members in a PodGroup caused task validity checks to fail during scheduling

[volcano-sh-bot]

This is an automated cherry-pick of #4803

NONE

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shinytang6 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @volcano-sh-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the scheduler's JobInfo processing where dynamic updates to PodGroup task member specifications were not correctly reflected, leading to erroneous task validity checks. The fix involves ensuring that the internal TaskMinAvailable map is properly reset before being updated, preventing stale data from interfering with scheduling decisions. Comprehensive unit tests have been introduced to cover various scenarios of task member changes, guaranteeing the robustness of this correction.

Highlights

• Fix for Task Validity Checks: Addressed an issue where changes to task members in a PodGroup could lead to failed task validity checks during scheduling due to stale data.
• TaskMinAvailable Map Clearing: The ParseMinMemberInfo function now explicitly clears the TaskMinAvailable map before re-populating it, ensuring it always reflects the current PodGroup specification.
• Comprehensive Test Coverage: New unit tests were added to job_info_test.go to validate the correct behavior of ParseMinMemberInfo when PodGroup task members are modified, covering various scenarios like additions, removals, and complete replacements of task roles.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where updates to a PodGroup's task members were not correctly propagated during scheduling, potentially causing task validity checks to fail. The fix is straightforward and correct: it clears the JobInfo.TaskMinAvailable map before repopulating it from the PodGroup specification. This ensures that any removed task members are no longer considered. A new suite of unit tests has been added to job_info_test.go which thoroughly covers various update scenarios, including decreasing, increasing, and replacing task members, confirming the bug is resolved. The changes are sound and improve the robustness of the scheduler.

[JesseStutler]

/retest