[release-1.12] Cherry-pick #4786 and #4792 #4843
Conversation
…roup-related information Signed-off-by: zjh <zhongjiahua@medlinker.com>
Replicasets have created a podgroup that wasn't used by the pods when the "scheduling.k8s.io/group-name" annotation was on the pods. Signed-off-by: Hajnal Máté <hajnalmt@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @hajnalmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates two critical fixes into the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
volcano-sh-bot
added
the
size/S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cherry-picks two fixes related to PodGroup handling for ReplicaSets. My review identifies two main issues. First, a change in pg_controller.go uses a Go 1.22+ feature (for range over an integer) which could break the build for the release-1.12 branch if it uses an older Go version; I've recommended reverting this for compatibility. Second, in pg_controller_handler.go, the logic to prevent creating unnecessary PodGroups is flawed and incorrectly blocks legitimate updates to existing PodGroups, which is a regression. I've suggested a corrected logic to fix this while still achieving the original goal.
| // In the upgrade scenario, need to synchronize and update the podgroup-related information. | ||
| // For example, if you update `scheduling.volcano.sh/group-min-member: "2"`, the podgroup's `minMember` needs to be updated to 2. | ||
| err := pg.createOrUpdateNormalPodPG(&pod) | ||
| if err != nil { |
There was a problem hiding this comment.
I am concerned we donot even have a test for this bug fix
There was a problem hiding this comment.
This bothers me too. 👍 shall I write one? Maybe we don't need in these cherrypicks but it would be good to be present at least on master.
#4786 didn't have one and I just cherrypicked it.
3 participants
What type of PR is this?
Cherry-picking to the release-1.12 branch:
Relevant part of:
#4792
and:
#4786
Which issue(s) this PR fixes:
Fixes #4827
Does this PR introduce a user-facing change?