fix: vgpu metrics repeated accumulation error #3893
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @yaoyinnan! |
volcano-sh-bot
added
the
size/S
|
@archlitchi Please help me review. thanks. |
yaoyinnan
force-pushed
the
fix/vgpu-metrics
branch
from
bfd1ba8 to
5a02567
Compare
Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
yaoyinnan
force-pushed
the
fix/vgpu-metrics
branch
from
5a02567 to
fef3241
Compare
|
/lgtm by the way, do you have a related issue submitted? |
|
/ok-to-test |
volcano-sh-bot
added
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
please make CI happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vgpu metrics
vgpu_device_allocated_memoryandvgpu_device_allocated_coreshave cumulative errors due to repeated calculations.AddResource()/SubResource()calculates them once before callingAddPodMetrics()/SubPodMetrics()and should not be calculated again.Signed-off-by: yaoyinnan 35447132+yaoyinnan@users.noreply.github.com