fix enable node device score plugin #3578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/M
|
/assign @shinytang6 |
shinytang6
suggested changes
Jul 11, 2024
Signed-off-by: coldzerofear <coldzerofear@outlook.com>
coldzerofear
force-pushed
the
fix-device-score
branch
from
f2cf893 to
2ed4d7e
Compare
volcano-sh-bot
added
the
needs-rebase
volcano-sh-bot
removed
the
needs-rebase
|
yes:) thanks for fixing /lgtm |
lowang-bh
reviewed
Dec 18, 2024
| if ok { | ||
| dsp.schedulePolicy = args[SchedulePolicyArgument].(string) | ||
| } | ||
| args.GetString(&dsp.schedulePolicy, SchedulePolicyArgument) |
There was a problem hiding this comment.
Please use space insead of Tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node device score is currently not usable