Volcano automatically releases the corresponding helm charts package #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangyang <wangyang8126@gmail.com>
volcano-sh-bot
added
the
size/L
|
/priority important-soon |
volcano-sh-bot
added
the
priority/important-soon
Signed-off-by: wangyang <wangyang8126@gmail.com>
wangyang0616
force-pushed
the
feature_chart_release_action
branch
from
6492dd0 to
621f2c1
Compare
hwdef
reviewed
May 19, 2023
| CHART_ORIGIN_PATH=${VK_ROOT}/installer/helm/chart | ||
| CHART_OUT_PATH=${RELEASE_FOLDER}/chart | ||
| cp -r "${CHART_ORIGIN_PATH}" "${CHART_OUT_PATH}" | ||
| sed -i "s|image_tag_version: \"latest\"|image_tag_version: \"${VOLCANO_IMAGE_TAG}\"|g" $(find ${CHART_OUT_PATH} -type f | grep values.yaml) |
There was a problem hiding this comment.
As far as I know, the sed command behaves inconsistently on linux and darwin, is there a way without using sed
There was a problem hiding this comment.
done, refer to: #2848
| #!/bin/bash | ||
|
|
||
| # | ||
| # Copyright 2021 The Volcano Authors. |
There was a problem hiding this comment.
done, refer to: #2848
|
It's cool to generete the helm charts automatically :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Requirement:
refer: #2766,
Volcano can be installed through helm at present, but you need to download the source code of the entire warehouse, the operation is relatively troublesome, and it does not conform to the standard usage of helm.
Target:
Build the helm repo corresponding to Volcano, and automatically publish helm charts.
Users can view the latest released packages through
helm repo update, and install and use them throughhelm installaccomplish:
(It is automatically completed through github action without manual intervention.)
(It is automatically completed through github action without manual intervention.)