Add enqueue-action.md doc #2664

zbbkeepgoing · 2023-02-01T02:43:32Z

Enqueue action doc not exist in design doc, so add it.

Signed-off-by: Binbin Zou binbin.zou@kyligence.io

zbbkeepgoing · 2023-02-01T02:46:38Z

docs/design/enqueue-action.md

+
+### 1. QueueOrderFn:
+#### Priority:
+Compares queuePriority set in Spec(using PriorityClass) and returns the decision of comparison between two priorities.


related to #2656

hwdef · 2023-02-01T06:11:23Z

docs/design/enqueue-action.md

+
+When the minimum number of resource requests under a job can not be met, even if the scheduling action is 
+performed for pod under a Job, pod will not be schedule because the "Gang" constraint is not reached. 
+state of job only allowed change from `Pending` to `Inqueue` if the minimum resource size of the job is met.


Suggested change

state of job only allowed change from `Pending` to `Inqueue` if the minimum resource size of the job is met.

State of job only allowed change from `Pending` to `Inqueue` if the minimum resource size of the job is met.

done, thks.

hwdef · 2023-02-01T06:14:39Z

docs/design/enqueue-action.md

+performed for pod under a Job, pod will not be schedule because the "Gang" constraint is not reached. 
+state of job only allowed change from `Pending` to `Inqueue` if the minimum resource size of the job is met.
+
+Enqueue action is the preparatory stage in the scheduling process. it can prevent a large number of 


Suggested change

Enqueue action is the preparatory stage in the scheduling process. it can prevent a large number of

Enqueue action is the preparatory stage in the scheduling process. It can prevent a large number of

done, thks.

jiangkaihua · 2023-02-02T03:44:10Z

docs/design/enqueue-action.md

+Each resource type of the minResource of the current job lessEqual the resourceQuota of the namespace, the job status is allowed to change from `Pending` to  `Inqueue`, otherwise it will be rejected.
+
+#### SLA:
+Job pending state waiting timeout, the job status is allowed to change from `Pending` to  `Inqueue`, otherwise it will be rejected.


Actually, SLA plugin would not REJECT job if its sla-waiting-time was not reached, it would just abstain and leave the decision to other plugins such as overcommit:

volcano/pkg/scheduler/framework/session_plugins.go

Lines 393 to 419 in ac21d08

// JobEnqueueable invoke jobEnqueueableFns function of the plugins

func (ssn *Session) JobEnqueueable(obj interface{}) bool {

var hasFound bool

for _, tier := range ssn.Tiers {

for _, plugin := range tier.Plugins {

if !isEnabled(plugin.EnabledJobEnqueued) {

continue

}

fn, found := ssn.jobEnqueueableFns[plugin.Name]

if !found {

continue

}

res := fn(obj)

if res < 0 {

return false

}

if res > 0 {

hasFound = true

}

}

// if plugin exists that votes permit, meanwhile other plugin votes abstention,

// permit job to be enqueueable, do not check next tier

if hasFound {

return true

}

}

I think this description is only the behavior of sla plugin, For the overall control of jobEnqueueable, I added a description as a whole.

Yes, I mean that SLA plugin behavior is different with other plugins, which would never reject podgroup from pending to inqueue. So the description otherwise it will be rejected should be modified.

Yes, It will be abstained, thks.

jiangkaihua · 2023-02-02T03:46:38Z

docs/design/enqueue-action.md

+
+1. QueueOrderFn(Plugin: Priority, DRF, Proportion),
+2. JobOrderFn(Plugin: Priority, DRF, Gang),
+3. JobEnqueueable(Plugin: OverCommit, Proportion, ResourceQuota, SLA),


JobEnqueued(Plugin: OverCommit)

This interface was used to update resource infos after one job turned inqueue, overcommit plugin need this interface to update inqueue resources in each queue and whole cluster.

done, thks.

hwdef

/lgtm

Signed-off-by: Binbin Zou <binbin.zou@kyligence.io> update doc Signed-off-by: Binbin Zou <binbin.zou@kyligence.io> update doc Signed-off-by: Binbin Zou <binbin.zou@kyligence.io>

stale · 2023-06-10T01:20:51Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

hwdef

/lgtm

hwdef · 2023-06-11T13:46:42Z

Please close and reopen this PR to retrigger the CI

stale · 2023-08-12T05:53:41Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

hwdef · 2023-09-17T05:03:45Z

/reopen

volcano-sh-bot · 2023-09-17T05:03:48Z

@hwdef: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot · 2023-09-17T05:03:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lowang-bh · 2023-12-22T14:24:39Z

/reopen

volcano-sh-bot · 2023-12-22T14:24:43Z

@lowang-bh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stale · 2024-03-17T09:30:30Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

lowang-bh · 2024-05-01T13:54:34Z

/remove lifecycle-stale

volcano-sh-bot added the retest-not-required-docs-only label Feb 1, 2023

volcano-sh-bot requested review from k82cn and merryzhou February 1, 2023 02:43

volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2023

zbbkeepgoing commented Feb 1, 2023

View reviewed changes

hwdef reviewed Feb 1, 2023

View reviewed changes

jiangkaihua reviewed Feb 2, 2023

View reviewed changes

zbbkeepgoing force-pushed the enqueue_action_doc branch 2 times, most recently from dea085f to 75c5c38 Compare February 3, 2023 09:41

hwdef reviewed Mar 8, 2023

View reviewed changes

volcano-sh-bot assigned hwdef Mar 8, 2023

volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023

add enqueue action doc

6195ce9

Signed-off-by: Binbin Zou <binbin.zou@kyligence.io> update doc Signed-off-by: Binbin Zou <binbin.zou@kyligence.io> update doc Signed-off-by: Binbin Zou <binbin.zou@kyligence.io>

zbbkeepgoing force-pushed the enqueue_action_doc branch from 2562431 to 6195ce9 Compare March 28, 2023 09:19

volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2023

hwdef reviewed Jun 11, 2023

View reviewed changes

volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2023

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2023

zbbkeepgoing closed this Jun 12, 2023

zbbkeepgoing reopened this Jun 12, 2023

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2023

stale bot closed this Sep 17, 2023

volcano-sh-bot reopened this Sep 17, 2023

stale bot closed this Oct 15, 2023

volcano-sh-bot reopened this Dec 22, 2023

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2023

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2024

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add enqueue-action.md doc #2664

Add enqueue-action.md doc #2664

zbbkeepgoing commented Feb 1, 2023

zbbkeepgoing Feb 1, 2023

hwdef Feb 1, 2023

zbbkeepgoing Feb 3, 2023

hwdef Feb 1, 2023

zbbkeepgoing Feb 3, 2023

jiangkaihua Feb 2, 2023

zbbkeepgoing Feb 3, 2023 •

edited

Loading

jiangkaihua Feb 3, 2023

zbbkeepgoing Feb 3, 2023

jiangkaihua Feb 2, 2023

zbbkeepgoing Feb 3, 2023

hwdef left a comment

stale bot commented Jun 10, 2023

hwdef left a comment

hwdef commented Jun 11, 2023

stale bot commented Aug 12, 2023

hwdef commented Sep 17, 2023

volcano-sh-bot commented Sep 17, 2023

volcano-sh-bot commented Sep 17, 2023

lowang-bh commented Dec 22, 2023

volcano-sh-bot commented Dec 22, 2023

stale bot commented Mar 17, 2024

lowang-bh commented May 1, 2024

	state of job only allowed change from `Pending` to `Inqueue` if the minimum resource size of the job is met.
	State of job only allowed change from `Pending` to `Inqueue` if the minimum resource size of the job is met.

	Enqueue action is the preparatory stage in the scheduling process. it can prevent a large number of
	Enqueue action is the preparatory stage in the scheduling process. It can prevent a large number of

	// JobEnqueueable invoke jobEnqueueableFns function of the plugins
	func (ssn *Session) JobEnqueueable(obj interface{}) bool {
	var hasFound bool
	for _, tier := range ssn.Tiers {
	for _, plugin := range tier.Plugins {
	if !isEnabled(plugin.EnabledJobEnqueued) {
	continue
	}
	fn, found := ssn.jobEnqueueableFns[plugin.Name]
	if !found {
	continue
	}

	res := fn(obj)
	if res < 0 {
	return false
	}
	if res > 0 {
	hasFound = true
	}
	}
	// if plugin exists that votes permit, meanwhile other plugin votes abstention,
	// permit job to be enqueueable, do not check next tier
	if hasFound {
	return true
	}
	}

Add enqueue-action.md doc #2664

Are you sure you want to change the base?

Add enqueue-action.md doc #2664

Conversation

zbbkeepgoing commented Feb 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zbbkeepgoing Feb 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hwdef left a comment

Choose a reason for hiding this comment

stale bot commented Jun 10, 2023

hwdef left a comment

Choose a reason for hiding this comment

hwdef commented Jun 11, 2023

stale bot commented Aug 12, 2023

hwdef commented Sep 17, 2023

volcano-sh-bot commented Sep 17, 2023

volcano-sh-bot commented Sep 17, 2023

lowang-bh commented Dec 22, 2023

volcano-sh-bot commented Dec 22, 2023

stale bot commented Mar 17, 2024

lowang-bh commented May 1, 2024

zbbkeepgoing Feb 3, 2023 •

edited

Loading