Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade golangci-lint to v1.50.0; #2537

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

waiterQ
Copy link
Contributor

@waiterQ waiterQ commented Oct 14, 2022

fix CI Verify codes error.

before: had some errors

after: no errors anymore

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2022
@waiterQ waiterQ force-pushed the fix-golangci-lint branch 2 times, most recently from 1fe8143 to 04c98f0 Compare October 14, 2022 06:55
Signed-off-by: shaoqiu <516595344@qq.com>
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@volcano-sh-bot volcano-sh-bot merged commit 6aa1b61 into volcano-sh:master Oct 14, 2022
@waiterQ waiterQ deleted the fix-golangci-lint branch October 25, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants