Can not sync job status correctly when upgrading from v1.5

[yuyue9284]

What happened:

When upgrading volcano from the v1.5 to later version, the already running job created by the v1.5 volcano cannot be correctly handled.

Anything else we need to know?:

v1.5 changed the naming logics of pod group by adding UID into the name: #2140, and there is also another fix regarding handling the already created pod group without UID in create or update: #2400. But a similar fix does not exist in the syncJob function.

So, in the following part the syncTask won't be set to true.

volcano/pkg/controllers/job/job_controller_actions.go

Lines 280 to 293 in 1a696ee

	var syncTask bool
	pgName := job.Name + "-" + string(job.UID)
	if pg, _ := cc.pgLister.PodGroups(job.Namespace).Get(pgName); pg != nil {
	if pg.Status.Phase != "" && pg.Status.Phase != scheduling.PodGroupPending {
	syncTask = true
	}
	for _, condition := range pg.Status.Conditions {
	if condition.Type == scheduling.PodGroupUnschedulableType {
	cc.recorder.Eventf(job, v1.EventTypeWarning, string(batch.PodGroupPending),
	fmt.Sprintf("PodGroup %s:%s unschedule,reason: %s", job.Namespace, job.Name, condition.Message))
	}
	}
	}

Environment:

• Volcano Version:
• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[Monokaix]

Yeah you're right, we haven't consider the old pg format when syncjob: )

[Monokaix]

/good-first-issue

[volcano-sh-bot]

@Monokaix:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[QingyaFan]

/assign

[Monokaix]

fixed by #3786

[Monokaix]

/close

[volcano-sh-bot]

@Monokaix: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.