Fix randomization for enums with single value #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there,
I hit a bug that panicked the tests with:
panic: invalid argument to Intn
The problem happened, because I have a Postgres `ENUM` with a single
value, that caused a `rand.Intn(0)` call, which panics on zero.
See: https://golang.org/src/math/rand/rand.go?s=4112:4142#L129
hawkgs
approved these changes
Jun 14, 2017
|
Thank you for fixing this. @aarondl Looks good to merge, yeah? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I hit a bug that panicked the generated tests with:
The problem happened, because I have a Postgres
ENUMwith a singlevalue, that caused a
rand.Intn(0)call, which panics on zero.See: https://golang.org/src/math/rand/rand.go?s=4112:4142#L129