Migrate lib/pq to jackc/pgx/v5 #1403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan93412
force-pushed
the
switch-to-pgx-v5
branch
from
6b20a35
to
57cb284
Compare
PostgreSQL 15.7 has a new default setting. To ensure the following jackc/pgx migration doesn't encounter any breaking changes, I've updated the default to the latest value provided by the lib/pq library.
pan93412
force-pushed
the
switch-to-pgx-v5
branch
from
57cb284
to
d1cd85c
Compare
Use stdlib compatibility layer to prevent possible breaking changes. Update TestSingleton's ThirdParty declaration to pgx/v5/stdlib.
pan93412
force-pushed
the
switch-to-pgx-v5
branch
from
d1cd85c
to
2845d08
Compare
Seems |
|
@stephenafamo can you check this? |
I don't think it can be merged soon. This project needs to upgrade the Go version to use My branch currently matches the |
|
The driver is only used to read the database during generation and the user is free to use whatever Since there is no benefit to upgrading, we will just stick with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/pqtopgx/v5's compatibility layer (to prevent rewriting too many things)lib/pq's dependenciesIt has not been thoroughly tested (except for the tests). If there are any other real-world cases that can be used for testing, I would greatly appreciate it.
Fixed #996
Fixed #759