Issue #569: excludePropertyAnnotations not respected when using gson #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The excludePropertyAnnotations property is not respected when using gson as JsonLibrary. * Configured an exclusion strategy on the GsonParser to fix the issue * Adjusted the IncludeExcludePropertyTest to reveal the issue and check the fix.
robin-xyzt-ai
commented
Nov 2, 2020
| @Parameterized.Parameters(name = "{index} - {0}") | ||
| public static Collection<Object[]> data() { | ||
| return Arrays.stream(JsonLibrary.values()) | ||
| .filter(library -> library != JsonLibrary.jackson1 && library != JsonLibrary.jsonb) |
There was a problem hiding this comment.
Ideally this wouldn't be needed.
But the test still fails for jackson1 and jsonb, so I excluded those
There was a problem hiding this comment.
Jackson1 is not developed anymore, jsonb is developed by the community so maybe somebody will implement it.
|
Thanks for your PR, merging. |
|
Thanks. Quick question: what is the schedule to publish new releases into maven so that I know when I can download a patched version from there ? |
|
Sorry for late response, released in v2.27.744. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The excludePropertyAnnotations property is not respected when using gson
as JsonLibrary.
the fix.