fix(select): handle Ctrl+U in task picker - #678
Conversation
Crossterm decodes Ctrl+U as Char('u') with CONTROL, which fell through modifier-agnostic text handling. Clear the query for Ctrl+U and restrict text insertion to unmodified or Shift keys so control sequences cannot enter search text.
Co-authored-by: GPT-5 Codex <codex@openai.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2e46608a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Allow printable Ctrl+Alt character events used by AltGr while keeping Ctrl+U limited to the exact control shortcut. Co-authored-by: GPT-5.6 Codex <codex@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Motivation
On macOS, Cmd+Backspace is sent to the terminal as Ctrl+U. Crossterm decodes it as a control-modified
u, but the task picker appended every character event to the search query, inserting a literalu.This PR makes Ctrl+U clear the query and reset the selection. It also limits search text to unmodified and Shift character events so other modified control keys are ignored.
🤖 Generated with Codex