feat(cli): bootstrap rust addon - #27
Merged
Merged
Conversation
wan9chi
approved these changes
Jul 21, 2025
| } else if (process.platform === 'freebsd') { | ||
| if (process.arch === 'x64') { | ||
| try { | ||
| return require('./vite-plus.freebsd-x64.node'); |
Member
There was a problem hiding this comment.
I see only macOS/Windows/Linux targets are listed in napi.targets in package.json.
Is it expected to see freebsd and other unlisted OSes/arches here?
Member
Author
There was a problem hiding this comment.
The binding template contains all NAPI-RS supported platform/cpu combination
fengmk2
added a commit
that referenced
this pull request
Jul 1, 2026
When migration keeps an opt-in browser provider (@vitest/browser-playwright / @vitest/browser-webdriverio) and adds its runtime framework peer, it wrote `playwright`/`webdriverio` as `*` (non-deterministic). Reuse a declared lockstep sibling's version instead (e.g. @playwright/test for playwright), resolving a `catalog:` sibling to its concrete value, referencing the catalog when it already owns the peer, and falling back to `*` only when nothing resolves (npmx.dev #27). Also extracts a shared findDeclaredSpec helper (the four-field dependency scan) and drops an unreachable peer branch in the REMOVE_PACKAGES loop. Claude-Session: https://claude.ai/code/session_01DQhS6o1fyQd1yjiee6W8jR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.