Follow-up to #2350. This does not block the current fix.
crates/vp_command/src/lib.rs currently searches PATH entries individually because the released version of which_in does not resolve ordinary relative PATH entries against its provided cwd.
Upstream fix: harryfei/which-rs#128
Follow-up work
Once the upstream fix is merged and released:
- update the workspace
which dependency in Cargo.toml and regenerate Cargo.lock
- remove
is_plain_relative_path and resolve_bin_from_path_entry from crates/vp_command/src/lib.rs
- replace the explicit-path branch and per-entry lookup in
resolve_bin with one which::which_in(bin_name, Some(path_env), cwd) call
- keep behavior tests for relative entries, lookup order, Unix empty entries, a Unix cwd containing
:, explicit relative programs, and the cross-platform CLI snapshot
- remove only the helper-specific Windows classification tests after the helpers are deleted
Related: #2326
Follow-up to #2350. This does not block the current fix.
crates/vp_command/src/lib.rscurrently searches PATH entries individually because the released version ofwhich_indoes not resolve ordinary relative PATH entries against its providedcwd.Upstream fix: harryfei/which-rs#128
Follow-up work
Once the upstream fix is merged and released:
whichdependency inCargo.tomland regenerateCargo.lockis_plain_relative_pathandresolve_bin_from_path_entryfromcrates/vp_command/src/lib.rsresolve_binwith onewhich::which_in(bin_name, Some(path_env), cwd)call:, explicit relative programs, and the cross-platform CLI snapshotRelated: #2326