Surface npm registry errors instead of the no-store guard - #20
Merged
Conversation
This reverts commit 2165eeb.
When the npm packument or time fetch returns a non-200 other than 404, throw npm's status + raw body instead of synthesizing a misleading packument (which drops the package's real versions and could be cached). 404 (not on npm) still synthesizes a preview-only packument. This supersedes the no-store guard (reverted above): on upstream failure the bridge errors out rather than serving a degraded packument.
fengmk2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related changes:
no-store-on-missing-time guard (Don't cache a packument that's missing npm time #19), it was more protection than warranted.Net: on an npm upstream failure the bridge errors out (client retries) instead of serving/caching a degraded packument. Reproducing test added; 57 pass.