fix: 全画面エフェクトが WebGL ビルドで描画されない問題を修正#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
WebGL (GLES3) で自作フルスクリーンエフェクトが描画されない問題に対して、URP RenderGraph での書き戻し方式を RenderGraphUtils.AddCopyPass 依存から、UniversalResourceData.cameraColor の差し替え(URP の推奨 blit パターン)へ変更する PR です。
Changes:
- VisionWarp / RadialBlur / RadialMonochrome の各 RendererFeature で、Blit 先を新規テクスチャに変更
AddCopyPassによる書き戻しを廃止し、resourceData.cameraColorを出力先へ差し替えるように変更- RenderGraph 内の一時テクスチャ命名を整理(
*_TempTexture→*_Texture)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CinematicEffect/VisionWarpRendererFeature.cs | CopyPass を廃止し、Blit 出力を cameraColor に差し替える方式へ変更 |
| CinematicEffect/RadialMonochromeRendererFeature.cs | 同上(RadialMonochrome 用) |
| CinematicEffect/RadialBlurRendererFeature.cs | 同上(RadialBlur 用) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
自作シェーダー系フルスクリーンエフェクト (VisionWarp / RadialBlur / RadialMonochrome) が WebGL ビルドで一切描画されない。書き戻しに使っていた RenderGraphUtils.AddCopyPass が framebuffer fetch (エミュレーション) 依存で、URP core が WebGL/GLES3 では明示的に非対応としているため (IsFramebufferFetchEmulationSupportedOnCurrentPlatform)。
変更点
動作確認