Skip to content

Save focus level on close - #18

Closed
ergl wants to merge 4 commits into
void-rs:masterfrom
ergl:focus_save
Closed

ergl wants to merge 4 commits into
void-rs:masterfrom
ergl:focus_save

Conversation

@ergl

@ergl ergl commented Dec 7, 2018

Copy link
Copy Markdown
Contributor

I often use deep trees, and currently every time you reopen void, the view gets reset to the home level. This makes it so the view stack and the current focus view are restored between runs. Maybe it's not the best way to things (just exposing fields with pub), but it might be helpful anyway.

The changes should work on existing documents, as all the new proto fields are optional, but I haven't done exhaustive testing of this.

@alok

alok commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

If I run this, it seems to clear my current document (good thing I backed up). Other than that it seems to work, and it doesn't clear its own doc.

@ergl

ergl commented Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

@alok Sorry to hear that! I should probably test this more. I did this change a long time ago and my document seems to work fine. Let me close it and I'll look at it again

@alok

alok commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

@ergl How did you autogenerate data_model.rs with the updated changes? I poked around the protobuf crate and had trouble figuring it out.

@ergl

ergl commented Mar 19, 2019

Copy link
Copy Markdown
Contributor Author

I installed the protobuf-codegen plugin for protoc. Once you have that installed, doing protoc --rust_out src/pb/ include/model.proto should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants