Fulldeptree fixups #146
Merged
Fulldeptree fixups #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and adds a test case for an issue we are currently experiencing, where orphaned are not correctly removed, if there are more than one package depending on the same package.
The main issue is that
xbps_get_pkg_fulldeptreeonly finds each dep it encounters once, adding the deps to the hashtable, but then never again adding them to any results.So if
xbps_get_pkg_fulldeptreeis called multiple times and the requested packages share dependencies in their fulldeptree, there are going to be packages missing from the results array.Another small thing I fixed is to not add the requested package itself to the results: