Skip to content

Conversation

@Calandracas606
Copy link
Contributor

@Calandracas606 Calandracas606 commented Feb 12, 2024

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64 (cross)
    • armv6l-musl (cross)

[ci skip]

@Calandracas606 Calandracas606 changed the title Llvm17 fix compiler cross Llvm17 fix compiler-rt, add liblldb17 Feb 12, 2024
@Calandracas606 Calandracas606 force-pushed the llvm17-fix-compiler-cross branch from 4f315af to bfa8b67 Compare February 12, 2024 21:59
_enabled_runtimes=

# use $(:) to silence xlint
_enabled_projects=$(:)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or initialize it with -DLLVM_ENABLE_PROJECTS=, but i don't care strongly.

@Calandracas606 Calandracas606 force-pushed the llvm17-fix-compiler-cross branch 2 times, most recently from 6a4540c to 72972f6 Compare February 14, 2024 16:44
@Calandracas606 Calandracas606 force-pushed the llvm17-fix-compiler-cross branch 2 times, most recently from 6d54cdc to 3457f33 Compare February 26, 2024 17:07
@Calandracas606 Calandracas606 marked this pull request as draft February 26, 2024 18:25
@Calandracas606
Copy link
Contributor Author

compiler_rt is failing to build on armv6l, since it is trying to use the ldrexd instruction which doesn't exist on armv6l

@Calandracas606 Calandracas606 force-pushed the llvm17-fix-compiler-cross branch from 3457f33 to af466bc Compare February 26, 2024 21:14
@Calandracas606 Calandracas606 marked this pull request as ready for review February 26, 2024 21:36
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 28, 2024
@github-actions github-actions bot closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants