Skip to content

feat: json variable access (VF-3664) #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MrPicklePinosaur
Copy link
Contributor

@MrPicklePinosaur MrPicklePinosaur commented Jun 1, 2022

Fixes or implements VF-3664

add ability to access array and object variables.

hello, my name is {name} and i currently work at {job.company}, my favourite ice cream flavour is {favIceCream[0]}

resolves to

hello, my name is bobby bob and i currently work at voiceflow, my favourite ice cream flavour is coffee

Brief description. What is this change?

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

Checklist

  • this is a breaking change and should publish a new major version
  • appropriate tests have been written

@MrPicklePinosaur MrPicklePinosaur force-pushed the daniel/json-access/VF-3664 branch from 8bda18c to 9189edb Compare June 1, 2022 19:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

81.5% 81.5% Coverage
0.0% 0.0% Duplication

@MrPicklePinosaur MrPicklePinosaur marked this pull request as ready for review June 1, 2022 19:12
@MrPicklePinosaur MrPicklePinosaur requested a review from trs June 1, 2022 19:16
@MrPicklePinosaur
Copy link
Contributor Author

might need to create special behavior to keep variables unexpanded in the case of index out of range or field not exist

Copy link
Contributor

@trs trs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for PR changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants