Prevent duplicate inserts into domain mapping logins table #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using this plugin along with the WP MU Domain Mapping plugin, it's possible for the same domain to be returned twice in the response for WP_Multisite_SSO::get_network_sites() if a domain is used as an alias of another blog. This commit removes duplicate domains from the return value here, so that we don't try to log into the same domain twice. (Logging into the same domain twice causes issues duplicate insert issues, because the blog ID of a domain is used along with the current timestamp to build the insert key in the wp_domain_mapping_logins table.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this plugin along with the WP MU Domain Mapping plugin, it's possible for the same domain to be returned twice in the response for WP_Multisite_SSO::get_network_sites() if a domain is used as an alias of another blog.
This commit removes duplicate domains from the return value here, so that we don't try to log into the same domain twice. (Logging into the same domain twice causes issues duplicate insert issues, because the blog ID of a domain is used along with the current timestamp to build the insert key in the wp_domain_mapping_logins table.)