Add abstractions to make it easier to declare and instantiate models - #605
Conversation
|
Still need to add tests for new classes, but current tests pass |
|
This should probably also include a very initial version of #37 that at least documents how these abstractions work, taken from my dev notes
|
ab74efb to
add8e16
Compare
5ab3635 to
e910c9c
Compare
fa70f59 to
75f3f39
Compare
1124b77 to
2994eb3
Compare
with classes used to parametrize tests
2994eb3 to
b374232
Compare
|
@yardencsGitHub tests for this now pass locally 😩 I found a way to make the abstractions a little more succinct than when we talked through it. Basically, there's just a single decorator Assuming tests pass on CI, I will go ahead and merge in. In the future let's do more async review, but I would really like to make progress on version 1.0 while I have a little time to focus on it. |
|
I am not understanding why the CI is failing. I think it may be related to this? I also thought it might be an old version of generated test data on the OSF repo but I tried downloading the generated data for ci locally and then running the tests the same way we do on CI, but this did not reproduce the error--the tests are running fine without failure It's also weird we get specific test failures but no error messages at the end: 2023-01-22T00:58:43.9564606Z nox > pytest --models teenytweetynet --cov=./ --cov-report=xml
2023-01-22T00:58:55.3302457Z ============================= test session starts ==============================
2023-01-22T00:58:55.3303545Z platform linux -- Python 3.9.16, pytest-7.2.1, pluggy-1.0.0
...
2023-01-22T01:14:45.8300540Z tests/test_core/test_predict.py FFFF.....
...
2023-01-22T01:52:59.9927859Z tests/test_models/test_base.py ......................FF..... [ 91%]
2023-01-22T01:53:00.0228373Z tests/test_models/test_decorator.py .............. [ 92%]
2023-01-22T01:53:00.0666356Z tests/test_models/test_definition.py .................... [ 93%]
2023-01-22T01:53:00.3391652Z tests/test_models/test_teenytweetynet.py .............. [ 94%]
2023-01-22T01:53:00.3856049Z tests/test_models/test_tweetynet.py ..s [ 94%]
2023-01-22T01:53:00.8246889Z tests/test_models/test_windowed_frame_classification_model.py .......... [ 95%]
2023-01-22T01:53:01.9587868Z ...............F
...Just going to go ahead and merge |
Fixes
vak.engine.Model#536See discussion in those issues