-
Notifications
You must be signed in to change notification settings - Fork 18
Schedule2 #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andreas Hubel <andreas.hubel@pub.tech>
@toto Sollen wir die kompletten Services hierher in schedule2 mit übernehmen?
|
Not all pick: that's historical baggage. How about
|
{ | ||
"guid": "3dc5daf5-ba21-4577-97e4-fb6e4b5d40e1", | ||
"name": "Art & Beauty", | ||
"colors": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're defining multiple colours, we should add a field for preferred colour scheme so apps know which to select in case there's no user choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional question would be if it really makes sense to have different colours for light and dark mode here, if the Conference
only defines a primary
and background
colour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind we don't always have that. For example, pretalx always uses light mode as of now, so that would be preferred. info-beamer in itself does also not know what the user preference is, so it would use the organizer preferences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. @saerdnaer It would be great to provide some context in the issue description up there and list all the clients which consume the JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we have a list of all the apps that might consume the json schedule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not have to be complete to be valuable.
"slug": "38c3-38c3-opening-ceremony", | ||
"title": "38C3: Opening Ceremony", | ||
"subtitle": null, | ||
"language": "en", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename language
to languages
? It is not limited to one language if I remember correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends if we want to include the languages of possible translations. If this is the language of the talk itself, there can only ever be one i think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe talks can still be hold in multiple languages, e.g. where speaker1 talks English and speaker2 talks German.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s have one language the talk is held in. If we want translations that should be a different field / indicated in some way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not refer to translations here. I really meant a talk which is hold in different languages and is therefore announced as such, e.g. en, de
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any system that currently supports this? AFAIK neither frab nor pretalx do; pretalx certainly assumes that a talk is in one language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember seeing it in the Android app at one point. I would need to investigate to find out what the source backend was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be that session with multiple languages originate from a wiki import at 38C3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for self-organized sessions created in the Hub, there is the option to select a ordered list of possible languages, via a dropdown with the options en
, de
, en, de
, de, en
.
In general I would see this field as main/original language and add an additional translations field and does not really like to force everybody to an array, only for the rare edge case that multiple languages are use in the same talk e.g. with multiple sections/speakers. That would be an complete other feature similar to chapters in a podcast episode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the UI for SOS look like / tell about the language selection? Are they being selected as the speakers languages or as the available translations?
Signed-off-by: Andreas Hubel <andreas.hubel@pub.tech>
"track": "CCC", | ||
"track": { | ||
"slug": "ccc" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I changed the track reference, to be uniform with the room reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing a reference to the guid
of the track here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not yet at the point where I see a track guid as really required, a persistent slug is a good enough "ID" for me for this kind of entity... Otherwise we have to discuss if they have the same guid across each conference instance etc.
Hmm, should we change all enum values to |
breaking changes to the schedule.json schema, thereby a own new version called
schedule2
, see 6632bbb for an comparison between the formatspublic_name
,daysCount
,timeslot_duration
, …color
->colors
to allow multiple color values e.g. for light an dark – and to be uniform to same attribute on Conferenceguid
fieldAccept
header"string"
to object{"en": "string", "de": "string"}
, but the old way is still allowedday_start
andday_end
get's unified tostart
andend
Participant
and has arole
attributelogo
andavatar
are now an object{"url": "uri-string"}
instead of"uri-string"
start
andend
instead ofdate
andduration
, fixing Clarify duration spec #129TODOs
Participant.role
should be an enumReference.service
enum based on ucdatalanguages: ['en', 'de']
onConference
defaults: { theme: 'dark', language: 'en' }
… onConference
?