dev #2
dev #2
Conversation
…nks (TinyActive#10) * feat: set base path for nginx-love documentation
…ctive#11) * feat: add GitHub Actions workflow to check documentation build
There was a problem hiding this comment.
Pull Request Overview
This PR appears to be a comprehensive rebranding effort from "nginx-love" to "nginx waf" throughout the documentation and configuration files. The changes include updating product names, removing demo credentials, adding development dependencies, and simplifying documentation content.
- Updates product branding from "nginx-love" to "nginx waf" across all documentation files
- Removes demo login credentials from the login component
- Adds terser as a new development dependency and creates a new docs build workflow
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/components/pages/Login.tsx | Removes demo credentials display |
| apps/docs/reference/troubleshooting.md | Updates product name and removes extensive troubleshooting sections |
| apps/docs/reference/faq.md | Updates product name and significantly reduces FAQ content |
| apps/docs/reference/configuration.md | Updates product name and simplifies configuration documentation |
| apps/docs/package.json | Adds terser dependency and reorders existing dependencies |
| apps/docs/index.md | Updates hero name and fixes navigation links |
| apps/docs/guide/*.md | Multiple guide files with product name updates and content simplification |
| apps/docs/.vitepress/config.ts | Updates documentation title and adds dead link ignoring |
| README.md | Adds Product Hunt badge |
| .github/workflows/*.yml | Updates Node.js version and adds new docs check workflow |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ### Is nginx waf free? | ||
|
|
||
| Yes, nginx-love is open-source and released under the MIT License. | ||
| Yes, nginx waf is open-source and released under the Apache-2.0 license. |
There was a problem hiding this comment.
Inconsistent license information. The original text mentioned 'MIT License' but this has been changed to 'Apache-2.0 license'. Verify which license is actually used for this project to ensure accuracy.
| Yes, nginx waf is open-source and released under the Apache-2.0 license. | |
| Yes, nginx waf is open-source and released under the MIT License. |
|
|
||
| **Domain Management** | ||
| - Create, edit, and delete domains | ||
| - Create, edit not delete domain |
There was a problem hiding this comment.
Grammar error in the text. Should be 'Create, edit, and delete domains' or 'Create and edit domains (not delete)'.
| - Create, edit not delete domain | |
| - Create and edit domains (not delete) |
| **Log Format**: | ||
| ``` | ||
| 2025-10-04T10:00:00.000Z [INFO] (nginx-love-api) User admin logged in successfully from 192.168.1.100 | ||
| 2025-10-04T10:00:00.000Z [INFO] (nginx-waf-api) User admin logged in successfully from 192.168.1.100 |
There was a problem hiding this comment.
The date '2025-10-04' appears to be a future date which may confuse readers. Consider using a more generic placeholder date like '2024-01-01' or using placeholders like 'YYYY-MM-DD'.
| 2025-10-04T10:00:00.000Z [INFO] (nginx-waf-api) User admin logged in successfully from 192.168.1.100 | |
| 2024-01-01T10:00:00.000Z [INFO] (nginx-waf-api) User admin logged in successfully from 192.168.1.100 |
| Threshold: 5% | ||
| Severity: Critical | ||
| Check Interval: 60 seconds (1 minute) | ||
| Check Interval: 10 seconds (5 minutes) |
There was a problem hiding this comment.
Inconsistent time units: '10 seconds (5 minutes)' should be either '10 seconds' or '5 minutes', not both. This creates confusion about the actual interval.
| Check Interval: 10 seconds (5 minutes) | |
| Check Interval: 10 seconds |
No description provided.