Display package post build (merge conflict resolution)#248
Open
intentionally-left-nil wants to merge 2 commits intovn971:masterfrom
Open
Display package post build (merge conflict resolution)#248intentionally-left-nil wants to merge 2 commits intovn971:masterfrom
intentionally-left-nil wants to merge 2 commits intovn971:masterfrom
Conversation
Bug: After building a package, pressing T to inspect returns an error This is because it tries to launch a shell with the path, however the path was just the filename, and not the full path. The fix is to ensure that path_str is the full path, and extract the basename as needed for displaying Fixes vn971#242
Otherwise, users installing multiple packages don't know what package the command is referring to. Fixes vn971#246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rebase of #247 on top of #244
If #244 is accepted, then this PR should be preferred instead of #247