Do not change install reason during upgrades#208
Open
InvalidUsernameException wants to merge 1 commit intovn971:masterfrom
Open
Do not change install reason during upgrades#208InvalidUsernameException wants to merge 1 commit intovn971:masterfrom
InvalidUsernameException wants to merge 1 commit intovn971:masterfrom
Conversation
Author
|
@vn971 Since you mentioned somewhere else that your email notifications weren't working in the past: Any chance you can take a look at this PR if you haven't seen it yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading AUR packages
ruaalways adds the--asdepsswitch to thepacmancommand line. That means that packages that were previously installed explicitly most likely end up as orphans because they have no other packages depending on them. This is annoying because it means one needs to runpacman -D --asexplicit <list of upgraded packages>after every upgrade of AUR packages to keep the install reasons correct and to prevent accidental uninstallation.This PR changes the behavior during upgrades to not include the
--asdepsswitch which means the install reasons of the upgraded packages stay unchanged.This should fix #169, but not the related #65, which seems different despite someone having commented that the issues are duplicates of each other.