examples: refactor a bit the examples #3127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoniivanov
commented
Feb 19, 2024
antoniivanov
commented
- moved the common storage code to vdk-storage library
- refactored confluence-reader to directly use it instead of using file
duyguHsnHsn
reviewed
Feb 19, 2024
yonitoo
reviewed
Feb 20, 2024
Contributor
yonitoo
left a comment
yonitoo
left a comment
There was a problem hiding this comment.
Looks good to me. Left 1 comment.
antoniivanov
force-pushed
the
person/aivanov/example
branch
2 times, most recently
from
19a752f to
30fb03a
Compare
duyguHsnHsn
reviewed
Feb 21, 2024
duyguHsnHsn
approved these changes
Feb 21, 2024
- moved the common storage code to vdk-storage library - refactored confluence-reader to directly use it instead of using file
antoniivanov
force-pushed
the
person/aivanov/example
branch
from
0213f42 to
ad7da50
Compare
for more information, see https://pre-commit.ci
yonitoo
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.