vdk-oracle: escape special chars in column names #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/oracle-special-chars
branch
from
70d6f92 to
7b97f67
Compare
antoniivanov
approved these changes
Jan 22, 2024
Contributor
antoniivanov
left a comment
antoniivanov
left a comment
There was a problem hiding this comment.
Looks good to me. None major comments. Mostly minor clean code suggestions.
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/oracle-special-chars
branch
from
7b97f67 to
2a09a24
Compare
Why? Special characters in column names currently cause errors. They should be supported in case the plugin is used for tables with unorthodox column names What? Support special characters in oracle column names Refactor column caching logic Special chars are escaped as advised here https://docs.oracle.com/en/error-help/db/ora-00904/ How was this tested? Ran functional tests locally CI/CD What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com> Export identifier normalization to separate function
DeltaMichael
force-pushed
the
person/mdilyan/oracle-special-chars
branch
from
4a71461 to
ab3cd1c
Compare
for more information, see https://pre-commit.ci
duyguHsnHsn
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Special characters in column names currently cause errors. They should be supported in case the plugin is used for tables with unorthodox column names
What?
Support special characters in oracle column names
Refactor column caching logic
Special chars are escaped as advised here
https://docs.oracle.com/en/error-help/db/ora-00904/
How was this tested?
Ran functional tests locally
CI/CD
What kind of change is this?
Feature/non-breaking
Signed-off-by: Dilyan Marinov mdilyan@vmware.com
Export identifier normalization to separate function