vdk-jupyter: Integration test CI step #2730
Conversation
Currently, logs made inside jobs using print statements are not positioned correctly within the vdk_logs file, but rather print logs are appended at the end of the file. This change fixes this by enabling the PYTHONUNBUFFERED env variable to ensure that print statements are not buffered and are written to the file immediately. Testing done: local test Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
This PR modifies the CICD of vdk-jupyter to run the integration tests. Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/jupyter-it Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
|
|
||
| integration-tests-vdk-jupyterlab-extension: | ||
| extends: .common-setup-vdk-jupyterlab-extension | ||
| stage: pre_release_test |
There was a problem hiding this comment.
You know that you can change the image wiht image: tag, right?
The default image use is python:3.8-alpine I can see from teh logs.
But the warning in the logs says that it isn't supported.
So you can change it to normal Ubuntu image or something else that is supported by playwright
There was a problem hiding this comment.
apparently the 'not supported' warning isn't a massive issue according to what I read
…on/gageorgiev/jupyter-it
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
| - export TZ=Europe/Minsk | ||
| - ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone |
There was a problem hiding this comment.
Why do we need to set the timezone to ours? AFAIK, we don't do that in other CI files. I think it might potentially cause some unwanted time discrepancies in the future.
| - pip install -U pip setuptools pre-commit | ||
| - apt install nodejs rustc cargo libffi-dev -y | ||
| - pip install jupyter |
There was a problem hiding this comment.
Can't we rely on the common setup instead of kinda duplicating the work there?
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…atile-data-kit into person/gageorgiev/jupyter-it
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/jupyter-it
|
Idk, whether this will be useful but u can check https://github.com/jupyterlab/jupyterlab-git/actions/runs/5753409851/workflow |
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
|
closing in favor of #2868 |
This PR modifies the CICD of vdk-jupyter to run the integration
tests.
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com