control-service: enable WebHook authentication #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/enable-webhooks-authentication
branch
from
321425c to
ff23116
Compare
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
changed the title
dakodakov
approved these changes
Aug 16, 2023
..._service/src/test/java/com/vmware/taurus/datajobs/webhook/PostCreateWebHookProviderTest.java
Show resolved
Hide resolved
mivanov1988
deleted the
person/miroslavi/enable-webhooks-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the Control Service lacks the capability to authenticate against the WebHook API. A specific customer of ours requires authentication for the WebHook API utilizing the same access token passed by the client to the Control Service APIs.
What
Incorporated logic to forward the oAuth2 access token to the WebHook API.
Testing Done
Unit and integration tests.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com