vdk-jupyter: Create init cell when opening new notebook #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that the necessary init cell is created automatically when opening an empty notebook. The specific logic goes as follows: first, we check if this is a new notebook by checking that it only has 1 empty cell. Then, we create the necessary cell, insert it and delete the previous one. Testing done: manual Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Contributor
|
Please, explain the problem you are trying to solve in the description, not just the solution. |
Contributor
|
Code flows like a stream, |
antoniivanov
reviewed
Jul 4, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/Untitled.ipynb
Outdated
Show resolved
Hide resolved
Contributor
I think the Haiku was too subtle? I think we need tests for the change. |
duyguHsnHsn
reviewed
Jul 5, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/Untitled.ipynb
Outdated
Show resolved
Hide resolved
DeltaMichael
reviewed
Jul 5, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/initVDKCell.ts
Outdated
Show resolved
Hide resolved
DeltaMichael
reviewed
Jul 5, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/initVDKCell.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Contributor
|
Can you add screen recording on how it works? |
Contributor
Author
|
@duyguHsnHsn the cell is filled in when you open a notebook, there is nothing to screen record |
duyguHsnHsn
reviewed
Jul 7, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/initVDKCell.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
murphp15
approved these changes
Jul 14, 2023
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/jupyter-load-config Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
duyguHsnHsn
reviewed
Jul 21, 2023
...plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts
Show resolved
Hide resolved
duyguHsnHsn
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integration with Jupyter requires two magic commands
plus a line of Python code to be ran before it can work. Currently,
users need to copy and paste these from previous notebooks
into new ones. It would probably be better if this was automated.
This PR ensures that the necessary init cell is created
automatically when opening an empty notebook. The specific
logic goes as follows: first, we check if this is a new
notebook by checking that it only has 1 empty cell. Then,
we create the necessary cell, insert it and delete the previous
one.
Testing done: manual
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com