Skip to content

control-service: better error logging and pull private image in private test #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murphp15 merged 3 commits into from
May 30, 2023
Merged

control-service: better error logging and pull private image in private test #2156

murphp15 merged 3 commits into from
May 30, 2023

Conversation

@murphp15
Copy link
Contributor

@murphp15 murphp15 commented May 30, 2023 •
edited
Loading

Why

  1. When the job fails we want to know the reason and not just the status
  2. We are now using github to pull public images from to avoid docker hub throttling. In doing this the private image test was no longer using a private image. Now it is using a private image again.

What

  1. If the status code is not 200 log the response body
  2. pull a private image

murphp15 and others added 3 commits May 29, 2023 19:20
@murphp15
control-service: use public image from github repo
aef40a2 
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15
control-service: better error logging
c78b8e3 
Signed-off-by: murphp15 <murphp15@tcd.ie>
Google Java Format
6abf366
@murphp15 murphp15 changed the title control-service: better error logging control-service: better error logging and pull private image in private test May 30, 2023
@murphp15 murphp15 requested review from antoniivanov and ivakoleva and removed request for ivakoleva May 30, 2023 09:00
@murphp15 murphp15 enabled auto-merge (squash) May 30, 2023 09:01
@murphp15 murphp15 merged commit 973aa35 into main May 30, 2023
@murphp15 murphp15 deleted the person/murphp15/better_error_logging branch May 30, 2023 09:06
@ivakoleva
Copy link
Contributor

ivakoleva commented May 30, 2023

I don't understand what a "private image" is, is there any documented work on the subject so I can quickly check it out?
Where I anticipated to find such info:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakodakov dakodakov dakodakov approved these changes

@antoniivanov antoniivanov Awaiting requested review from antoniivanov

+1 more reviewer

@gabrielgeorgiev1 gabrielgeorgiev1 gabrielgeorgiev1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@murphp15 @ivakoleva @dakodakov @gabrielgeorgiev1 @vmwclabot