control-service: introduce latest and stable tags for docker images #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/control-service-tags
branch
5 times, most recently
from
039332e to
d49dd2d
Compare
Why Re-deploying the helm chart from a CI pipeline that is not related to control service, e.g. frontend, requires a way to track control service docker images other than commit hashes. What Introduce latest and stable tags for control service docker images. Each docker image is tagged with latest in the publish_artifacts stage. Once the image is deployed in the test environment and tests have run, it is tagged with stable. How was this tested Ran new and changed scripts locally. CI What type of change are you making Breaking change to CI Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/control-service-tags
branch
2 times, most recently
from
474c265 to
d0901e0
Compare
murphp15
approved these changes
May 30, 2023
mivanov1988
approved these changes
Jun 1, 2023
DeltaMichael
added a commit
that referenced
this pull request
Jun 9, 2023
Stacked on top of #2138 ## Why The frontend is now part of quickstart-vdk. On changes to the docker image, the helm chart needs to be redeployed. We need to make sure that the frontend is operational once the helm chart is deployed. ## What Trigger deployment of test control service on frontend changes merged into main Ping the frontend in the test environment using heartbeat once control service is deployed Tag the frontend image as stable if the test is successful ## How has this been tested [Test pipeline](https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/894015566) ## What kind of change is this feature, non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Re-deploying the helm chart from a CI pipeline that is not related to control service, e.g. frontend, requires a way to track control service docker images other than commit hashes.
What
Introduce latest and stable tags for control service docker images. Each docker image is tagged with latest in the publish_artifacts stage. Once the image is deployed in the test environment and tests have run, it is tagged with stable.
How was this tested
Ran new and changed scripts locally.
CI https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/882279167
What type of change are you making
Breaking change to CI