Skip to content

vdk-impala: stop using errors.get_exception_message - #1224

Merged
antoniivanov merged 2 commits into
mainfrom
person/aivanov/vdk-impala-change
Oct 10, 2022
Merged

vdk-impala: stop using errors.get_exception_message#1224
antoniivanov merged 2 commits into
mainfrom
person/aivanov/vdk-impala-change

Conversation

@antoniivanov

Copy link
Copy Markdown
Contributor

This will allow us to make it private in vdk-core. It's basically to string of the exception message. Seem overkill to have a vdk core inteface that shallow.

Teseting Done: vdk-impala tests

Signed-off-by: Antoni Ivanov aivanov@vmware.com

This will allow us to make it private in vdk-core. It's basically to
string of the exception message. Seem overkill to have a vdk core
inteface that shallow.

Teseting Done: vdk-impala tests

Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
@antoniivanov
antoniivanov force-pushed the person/aivanov/vdk-impala-change branch from 56cb8ba to a726bb3 Compare October 6, 2022 10:07

@doks5 doks5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoniivanov
antoniivanov enabled auto-merge (squash) October 10, 2022 09:15
@antoniivanov
antoniivanov merged commit d67f6da into main Oct 10, 2022
@antoniivanov
antoniivanov deleted the person/aivanov/vdk-impala-change branch October 10, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants