vdk-pipeline-control-plane: better error logging for transient error in tests - #1222
Merged
murphp15 merged 4 commits intoOct 5, 2022
Merged
Conversation
…in tests. When the tests fails it would be nice to know what the actual value is and not just that it doesn't match. Signed-off-by: murphp15 <murphp15@tcd.ie>
antoniivanov
approved these changes
Oct 5, 2022
murphp15
enabled auto-merge (squash)
October 5, 2022 19:32
murphp15
deleted the
person/murphp15/better_logging_during_test_failure
branch
October 5, 2022 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the tests fails it would be nice to know what the actual value is and not just that it doesn't match.
Here we can see the error is not nearly descriptive enough
https://vmware-analytics.gitlab.io/-/versatile-data-kit/-/jobs/3130654022/artifacts/projects/control-service/projects/pipelines_control_service/build/reports/tests/integrationTest/classes/com.vmware.taurus.datajobs.it.DataJobTerminationStatusIT.html#testDataJobTerminationStatus(String,%20String,%20String)
What
Added extra details to the error message.
Signed-off-by: murphp15 murphp15@tcd.ie