control-service: remove executables from secure job builder - #1202
Merged
Conversation
gabrielgeorgiev1
approved these changes
Oct 3, 2022
gabrielgeorgiev1
left a comment
gabrielgeorgiev1
left a comment
Contributor
There was a problem hiding this comment.
What about chmod? Also, fix the name of your PR.
mivanov1988
changed the title
mivanov1988
changed the title
Contributor
Author
The base image contains only chown, uname, sh, and python. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: In order to reduce the attack surface, we need to remove all unnecessary system executables after the job building.
What: The change aims to remove all left and unnecessary executables after job building - chown, uname and pip.
Testing done: built image locally.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com