-
Notifications
You must be signed in to change notification settings - Fork 64
Open
Labels
Description
What is the feature request? What problem does it solve?
VDKCS service for Kubernetes API communication needs usability improvement.
Suggested solution
- move KubernetesService to dedicated kubernetes package
- to simplify -> extract nested classes (JobStatus, JobStatusCondition, Resources, Probe, JobExecution, ContainerResourceType)
- for readability -> cleanup redundant private final field modifiers from @Value-annotated classes
- move to dedicated functions the content of afterPropertiesSet(), for example populateApiClient(), validateDataJobTemplate(), etc.
- what is health() unused method?
- organize the API surface -> group fields,getters/setters,contructor,methods by non-static/static then access modifier by public/package default/protected/private
- the sort the public group entries by logical purpose -> for example mark //namespace section then place createNamespace() then deleteNamespace(), mark //cronjob section then place listCronJobs(), readCronJob(), createCronJob()
- sort non-public group entries by purpose
- sort static public/non-public methods
- move static final fields to extending classes/util, based on usages
- refactor fromInteger and fromDateTime -> transform to (final) functions, eventually move to (final) utilities to reuse (JobStatus, JobStatusCondition, Resources, Probe)