Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve int overflow, add license #15

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

kremerpatrick
Copy link
Contributor

  • Resolves int overflow error caused by HCX operations taking an extended period of time
  • Adds Apache 2.0 license

Signed-off-by: Patrick Kremer <pk@kremerdev.com>
Signed-off-by: Patrick Kremer <pk@kremerdev.com>
Copy link
Contributor

@adeleporte adeleporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub token secret should be left to GITHUB_TOKEN

.github/workflows/release.yaml Show resolved Hide resolved
@kremerpatrick
Copy link
Contributor Author

Closes #13

@kremerpatrick
Copy link
Contributor Author

GitHub token secret should be left to GITHUB_TOKEN

This is no longer possible. Your existing secret can remain with the banned GITHUB_ prefix, but nobody can create a new secret with that prefix.

https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions

"Names must not start with the GITHUB_ prefix."

@adeleporte adeleporte merged commit d9e0265 into vmware:main Jan 22, 2024
Copy link

github-actions bot commented Jan 8, 2025

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants