Add: Support for Faraday 2.x#3232
Conversation
preetham
commented
Jul 17, 2025
preetham
commented
- Upgraded faraday gem to 2.x
- Fixed Psych issue with aliases. Ref: https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
preetham
force-pushed
the
g11n-ruby-client
branch
from
8c01fdf to
4b44753
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rubocop (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Please fix the action run. You should be able to run the action after every push form now on. |
|
@jhua-vmware Fixed the issues reported in the action run, please approve the action run for the changes. |
|
Can you fix unit/smoke test in https://github.com/vmware/singleton/actions/runs/16378688905? |
|
@jhua-vmware Tests are fixed, please verify. |
|
You need to set up gpg key to sign your commit, can you make one commit? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## g11n-ruby-client #3232 +/- ##
=================================================
Coverage 92.87% 92.87%
=================================================
Files 23 23
Lines 491 491
=================================================
Hits 456 456
Misses 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com> Update: Version Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com> Fix: Header pattern Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com> Fix: Smoke tests Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com> Fix: Unit tests Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com> Fix: Switch to safe_load Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com> Update: Switch to CodeQL v3 Signed-off-by: Preetham Kamidi <preetham.kamidi@broadcom.com>
preetham
force-pushed
the
g11n-ruby-client
branch
from
e9e32ae to
4d5e03b
Compare
|
@jhua-vmware Signed the latest commit, please verify. |
|
@jhua-vmware @sjiang-cb If the changes are good, can you please merge the PR? |
3 participants
