Python code gives error HTTPProxyConnection.call() missing 2 required positional arguments: 'port' and 'timeout'

[prashant1diwase]

Describe the bug

When we tried to connect with the below details, it started giving the below error with pyvmomi 8.0.3.0.1

Error

HTTPProxyConnection.call() missing 2 required positional arguments: 'port' and 'timeout'

Reproduction steps

When we tried to connect with the below details, it started giving the below error with pyvmomi 8.0.3.0.1

Code

    server = "146.89.140.53"
    httpsProxy ='http://146.72.882.22:3128'
    proxy = urlparse(httpsProxy)

    smart_stub = SmartStubAdapter(
        host=server,
        httpProxyHost=proxy.hostname,
        httpProxyPort=proxy.port,
        disableSslCertValidation=True,
    )

Expected behavior

It should be able to connect

Additional context

Analysis

However, when we checked further there was a change in implementation for pyvmomi 8.0.3.0.1 compared with pyvmomi 8.0.2.0.1.
When we applied the fix given in #1085, by changing committed files [connect.py, Security.py, SoapAdapter.py] (9a8956f) it gave different error -

Error

[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1006)')

[DanielDraganov]

Hi @prashant1diwase
An additional fix was applied after 9a8956f because the prior introduced a bug in the proxy connection's host and port initialization.
Please checkout the latest pyVmomi from the master branch and try again.

I couldn't reproduce the SSL issue so if by some chance you encounter an SSL error please post the traceback.