feat: improve code efficiency of Invoke-VcfHealthReport#60
Merged
Conversation
Improvements around code efficiency: - Added $commandSwitch to create the -allDomains or -workloadDomain and -failureOnly input for a command - Refactored all `Publish-` calls to use $commandSwitch resulting in single command per element and reduction of ten lines of code per element - 50% reduction in lines of code for Invoke-VcfHealthReport Signed-off-by: Gary Blake <gblake@vmware.com>
|
@GaryJBlake, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gary Blake <gblake@vmware.com>
GaryJBlake
force-pushed
the
feat-invoke-vcfhealthreport-efficiency
branch
from
520626d to
20ccddf
Compare
tenthirtyam
changed the title
Invoke-VcfHealthReport
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Improvements around code efficiency:
Publish-calls to use $commandSwitch resulting in single command per element and reduction of ten lines of code per elementSigned-off-by: Gary Blake gblake@vmware.com
Type of Pull Request
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
Breaking Changes?