feat: add component size checks#130
Merged
Merged
Conversation
Contributor
Author
|
tenthirtyam
added
do-not-merge
tenthirtyam
force-pushed
the
feat/add-component-size-checks
branch
from
0aa5999 to
0d8ec2e
Compare
- Added component size checks (e.g., tiny, x-small, small, etc...) for vCenter Server instances and NSX Local Manager clusters to the overview report. - Updates `CHANGELOG.md` - Updates module version from v2.1.0.1001 to v2.1.0.1002. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
force-pushed
the
feat/add-component-size-checks
branch
from
0d8ec2e to
fa7cd7d
Compare
tenthirtyam
commented
May 2, 2023
| if (Get-VCFEdgeCluster | Where-Object {$_.nsxtCluster.id -eq $domain.nsxtCluster.id}) { $edgeCluster = "True" } else { $edgeCluster = "False" } | ||
| if ($domain.type -eq "MANAGEMENT" -and (Get-VCFApplicationVirtualNetwork)) { $avnStatus = "True"} else { $avnStatus = "False" } | ||
| $customObject = New-Object -TypeName psobject | ||
| $nsxManagerNode = ($vcfNsxDetails = Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain sfo-m01 -listNodes).nodes | Select-Object -First 1 |
Contributor
Author
There was a problem hiding this comment.
Bug introduced whilst testing. Will fix this for v2.1.0.
tenthirtyam
pushed a commit
that referenced
this pull request
May 2, 2023
Updates `Request-NetworkOverview` to resolve a bug introduced in #130. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
11 tasks
tenthirtyam
pushed a commit
that referenced
this pull request
May 2, 2023
- Updates `Request-NetworkOverview` to resolve a bug introduced in #130. - Updates module version from v2.1.0.1004 to v2.1.0.1005. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
GaryJBlake
pushed a commit
that referenced
this pull request
May 3, 2023
- Updates `Request-NetworkOverview` to resolve a bug introduced in #130. - Updates module version from v2.1.0.1004 to v2.1.0.1005. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
CHANGELOG.mdType of Pull Request
Please describe:
Related to Existing Issues
Closes #71
Test and Documentation Coverage
Breaking Changes?