Skip to content

refactor: remove Invoke-VcfPasswordPolicy and supporting content#118

Merged
tenthirtyam merged 1 commit into
mainfrom
refactor/remove-password-policy
Apr 12, 2023
Merged

refactor: remove Invoke-VcfPasswordPolicy and supporting content#118
tenthirtyam merged 1 commit into
mainfrom
refactor/remove-password-policy

Conversation

@tenthirtyam
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam commented Apr 12, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Breaking: Removes Invoke-VcfPasswordPolicy and supporting content. Please use the VMware.CloudFoundation.PasswordManagement module.
  • Bumps the module version to v2.0.0.1006.
  • Updates CHANGELOG.md.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Documentation will be updated for the v2.0.0 release in a separate pull request.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added breaking-change Breaking Change refactor Refactor labels Apr 12, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 12, 2023
@tenthirtyam tenthirtyam self-assigned this Apr 12, 2023
@tenthirtyam tenthirtyam force-pushed the refactor/remove-password-policy branch 2 times, most recently from 3689386 to 8697641 Compare April 12, 2023 11:09
refactor: remove Invoke-VcfPasswordPolicy and supporting content
f318ce9 
- **Breaking**: Removes `Invoke-VcfPasswordPolicy` and supporting functions. Please use the `VMware.CloudFoundation.PasswordManagement` module.
- Bumps the module version to v2.0.0.1006.
- Updates `CHANGELOG.md`.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam force-pushed the refactor/remove-password-policy branch from 8697641 to f318ce9 Compare April 12, 2023 11:11
@tenthirtyam tenthirtyam marked this pull request as ready for review April 12, 2023 11:12
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 12, 2023 11:12
@tenthirtyam tenthirtyam requested a review from GaryJBlake April 12, 2023 11:12
GaryJBlake
GaryJBlake approved these changes Apr 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 01b4472 into main Apr 12, 2023
@tenthirtyam tenthirtyam deleted the refactor/remove-password-policy branch April 12, 2023 11:16
tenthirtyam pushed a commit that referenced this pull request Apr 12, 2023
docs: update README.md
768e2fe 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam mentioned this pull request Apr 12, 2023
Merged
11 tasks
tenthirtyam pushed a commit that referenced this pull request Apr 12, 2023
docs: update README.md
f72b563 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam pushed a commit that referenced this pull request Apr 13, 2023
docs: update README.md
6719707 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam pushed a commit that referenced this pull request Apr 14, 2023
docs: update README.md
0377598 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam pushed a commit that referenced this pull request Apr 18, 2023
docs: update README.md
0b192f4 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam pushed a commit that referenced this pull request Apr 24, 2023
docs: update README.md
133c16e 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam pushed a commit that referenced this pull request Apr 24, 2023
docs: update README.md
22a1820 
Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113
- Updates `CHANGELOG.md` with v.2.0.0 release date.
- Updates the module GUID for v2.0.0.
- Updates the module version and build to 2.0.0.1007.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam pushed a commit that referenced this pull request Apr 25, 2023
@GaryJBlake
docs: update README.md (#119)
4b42c50 
- Updates the `README.md` for the following:
- Removes the Password Policy report. Ref: #118
- Updates the PowerShell module dependencies. Ref:  #117
- Updates the minimum supported VMware Cloud Foundation version. Ref: #117
- Updates the use of `Test-VcfReportingPrereq`. Ref:  #117
- Updates the use of `Invoke-VcfHealthReport`. Ref:  #113
- Updates `CHANGELOG.md` with v.2.0.0 release date.
- Updates the module GUID for v2.0.0.
- Updates the module version and build to 2.0.0.1013.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Co-authored-by: Gary Blake <gblake@vmware.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

breaking-change Breaking Change refactor Refactor

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @GaryJBlake