Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding a Category to a ProductSection #35

Closed
xsacha opened this issue Oct 5, 2023 · 1 comment · Fixed by #36
Closed

Allow adding a Category to a ProductSection #35

xsacha opened this issue Oct 5, 2023 · 1 comment · Fixed by #36

Comments

@xsacha
Copy link

xsacha commented Oct 5, 2023

Is your feature request related to a problem? Please describe.

Currently all the OVF Properties are added as 'uncategorized' which is ugly and causes UI bloat at customisation time.

Describe the solution you'd like

The ability to put a category on an OVFProduct.

Describe alternatives you've considered

<ProductSection>
  <Info>Test</Info>
  <Product>Test Product</Product>
  <Vendor>Test Vendor</Vendor>
  <Version>1.0.0</Version>
  <FullVersion>Test</FullVersion>
  <Category>Hardware</Category> <!-- INJECT THIS -->
  <Property ovf:key="blah" ovf:type="int" ovf:value="2" ovf:userConfigurable="true">
    <Label>GPUs to use</Label>
    <Description>How many GPUs to use</Description>
  </Property>
</ProductSection>

Additional context

No response

@oliverkurth
Copy link
Contributor

Thanks for reporting. This makes sense, I will add this as soon as I find the time.

I was thinking about implementing it like this, by adding the categories to environment, and then they get referenced from the properties:

environment:
...
    categories:
        email:
            name: "Email Stuff"
        login:
            name: "Login Details"
    properties:
        guestinfo.admin.email:
            value: admin@company.org
            user_configurable: true
            type: string
            description: "The Admin's email address"
            label: "Email Address"
            category: email
        guestinfo.password:
            password: true
            user_configurable: true
            type: string
            description: "The Admin's Password"
            label: "Password"
            category: login

oliverkurth added a commit that referenced this issue Oct 24, 2023
@oliverkurth oliverkurth linked a pull request Oct 24, 2023 that will close this issue
oliverkurth added a commit that referenced this issue Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants