Merge pull request #59 from bo-gan-broadcom/topic/bogan/fix-slow-shasum

ova-compose: fix slowness of hashsum generation
vmware · Apr 29, 2024 · c4e8c5d · c4e8c5d
2 parents 941d4af + 4dbde2a
commit c4e8c5d
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/ova-compose/ova-compose.py b/ova-compose/ova-compose.py
@@ -1160,10 +1160,14 @@ def write_xml(self, ovf_file=None):
 
 
     @staticmethod
-    def _get_hash(filename, hash_type):
+    def _get_hash(filename, hash_type, blocksz=1024 * 1024):
         hash = hashlib.new(hash_type)
         with open(filename, "rb") as f:
-            hash.update(f.read())
+            while True:
+                buf = f.read(blocksz)
+                if not buf:
+                    break
+                hash.update(buf)
         return hash.hexdigest()