Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builds(deps): add vcsim to rpm #3413

Closed
smitterl opened this issue Apr 12, 2024 · 2 comments · Fixed by #3414
Closed

builds(deps): add vcsim to rpm #3413

smitterl opened this issue Apr 12, 2024 · 2 comments · Fixed by #3414
Labels
kind/feature

Comments

@smitterl
Copy link
Contributor

smitterl commented Apr 12, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
It completes the accepted change #3403

Describe the solution you'd like
The govmomi package should include the vcsim binary, too.

Describe alternatives you've considered
None
@smitterl
Copy link
Contributor Author

@dougm Thanks for accepting my change. I just noticed that vcsim is currently not part of the package. Slippage on my side because I don't use it. However, the package name 'govmomi' implies reasonably that all binaries should be included. So, I'll fix this.
If you think it makes sense to also build 'deb' packages for Debian derived distros, please let me know. It's easily added.

smitterl added a commit to smitterl/govmomi that referenced this issue Apr 12, 2024
@smitterl
build(deps): add vcsim to rpm
92a29eb 
Closes: vmware#3413

Previously, we enabled rpm builds. However, only 'govc' was added.
Let's add 'vcsim', too, as the package name 'govmomi' implies it.

Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
@smitterl smitterl mentioned this issue Apr 12, 2024
Merged
12 tasks
@smitterl smitterl changed the title builds(dep builds(deps): add vcsim to rpm Apr 12, 2024
@dougm
Copy link
Member

dougm commented Apr 12, 2024

That's cool, but let's wait on deb packages and we can add if requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): add vcsim to rpm smitterl/govmomi
2 participants
@dougm @smitterl