Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload License files for CSE #116

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Upload License files for CSE #116

merged 3 commits into from
Oct 1, 2018

Conversation

sahithi
Copy link
Collaborator

@sahithi sahithi commented Sep 27, 2018

Signed-off-by: sahithi sahithi.ayloo@gmail.com


This change is Reviewable

Signed-off-by: sahithi <sahithi.ayloo@gmail.com>
Copy link
Collaborator

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sahithi and @andrew-ni)


LICENSE.txt, line 10 at r1 (raw file):


Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
ï	Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

Change these characters viz. ï back to the dots. I had similar issues in the License files for pyvcloud and vcd-cli. The legal team probably copied stuff off MS Word and pasted them in a plain text file.

Signed-off-by: sahithi <sahithi.ayloo@gmail.com>
Signed-off-by: sahithi <sahithi.ayloo@gmail.com>
Copy link
Collaborator

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrew-ni)

Copy link
Collaborator

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrew-ni)

@sahithi sahithi merged commit 4db7a32 into vmware:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants