Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1alpha4 from CRDs #664

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Remove v1alpha4 from CRDs #664

merged 3 commits into from
Oct 8, 2024

Conversation

lzichong
Copy link
Contributor

@lzichong lzichong commented Oct 8, 2024

Description

Please provide a brief description of the changes proposed in this Pull Request

  • Remove v1alpha4 labels and regenerated CRDs with make manifests

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

@lzichong lzichong requested review from arunmk and sahithi October 8, 2024 18:26
Copy link
Collaborator

@sahithi sahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the final infrastruture-components.yaml?

Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an entry in PROJECT as well. However, the recommendation is to not edit that file directly. It is harmless for now and we can leave it. It may need to be changed when we add a new API version which is unlikely at this point.

Hence, LGTM.

Copy link
Collaborator

@sahithi sahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzichong lzichong merged commit 79c0ed4 into vmware:1.3.z Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants