Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15] Issue 8394: move closeDataPath outside callbacks #8402

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8394, don't call closeDataPath in VGDP callbacks, otherwise, the VGDP cleanup will hang

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.98%. Comparing base (1d4f147) to head (56cab06).
Report is 2 commits behind head on release-1.15.

Files with missing lines Patch % Lines
pkg/controller/pod_volume_backup_controller.go 0.00% 5 Missing ⚠️
pkg/controller/pod_volume_restore_controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #8402      +/-   ##
================================================
- Coverage         58.99%   58.98%   -0.02%     
================================================
  Files               367      367              
  Lines             38847    38854       +7     
================================================
  Hits              22918    22918              
- Misses            14467    14474       +7     
  Partials           1462     1462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit 13d8e7d into vmware-tanzu:release-1.15 Nov 13, 2024
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants